kgyrtkirk commented on code in PR #3280:
URL: https://github.com/apache/hive/pull/3280#discussion_r870520711
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -2506,13 +2506,13 @@ private Map<Object, Object> getQueryCache() {
}
@Override
- protected String getValidWriteIdList(String dbName, String tblName) {
+ protected String getValidWriteIdList(String catName, String dbName, String
tblName) {
Review Comment:
an alternate approach would be to replace arguments like this with a
`TableName`...so that we move forward with that refactor and use that object
more extensively;
I think bugs like this are simply just sideeffects of passing a set of
strings together - and sometimes miss one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
