rbalamohan commented on code in PR #2950:
URL: https://github.com/apache/hive/pull/2950#discussion_r871907679
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
##########
@@ -284,6 +285,19 @@ public static boolean checkIfDbNeedsToBeSkipped(Database
db) {
return false;
}
+ public static List<String> getReplicationDbProps() {
+ return Arrays.stream(ReplConst.class.getDeclaredFields())
+ .filter(field -> Modifier.isStatic(field.getModifiers()))
+ .map(field -> {
+ try {
+ String prop = (String) field.get(String.class);
+ return prop.replace("\"", "");
+ } catch (IllegalAccessException e) {
+ throw new RuntimeException(e);
Review Comment:
Log and add details about the reason for the error?
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
##########
@@ -284,6 +285,19 @@ public static boolean checkIfDbNeedsToBeSkipped(Database
db) {
return false;
}
+ public static List<String> getReplicationDbProps() {
+ return Arrays.stream(ReplConst.class.getDeclaredFields())
+ .filter(field -> Modifier.isStatic(field.getModifiers()))
+ .map(field -> {
+ try {
+ String prop = (String) field.get(String.class);
+ return prop.replace("\"", "");
+ } catch (IllegalAccessException e) {
+ throw new RuntimeException(e);
Review Comment:
Log and add details about the reason for the error for easier debugging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
