kasakrisz commented on code in PR #2855:
URL: https://github.com/apache/hive/pull/2855#discussion_r877912792


##########
ql/src/test/results/clientpositive/llap/acid_direct_update_delete_partitions.q.out:
##########
@@ -148,30 +156,50 @@ POSTHOOK: Input: default@test_update_part@c=11
 POSTHOOK: Input: default@test_update_part@c=22
 POSTHOOK: Input: default@test_update_part@c=33
 POSTHOOK: Input: default@test_update_part@c=__HIVE_DEFAULT_PARTITION__
+POSTHOOK: Output: default@test_update_part
+POSTHOOK: Output: default@test_update_part@c=11
 POSTHOOK: Output: default@test_update_part@c=11
 POSTHOOK: Output: default@test_update_part@c=22
+POSTHOOK: Output: default@test_update_part@c=22
 POSTHOOK: Output: default@test_update_part@c=33
 POSTHOOK: Output: default@test_update_part@c=__HIVE_DEFAULT_PARTITION__
+POSTHOOK: Output: default@test_update_part@c=__HIVE_DEFAULT_PARTITION__
+POSTHOOK: Lineage: test_update_part PARTITION(c=11).a SIMPLE []

Review Comment:
   With early split update we end up with a multi insert statement: all of the 
branches inserts to the same table. Hive collects the lineage info to a List 
not a Set and while traversing all insert branches. This leads to duplicates.



##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerCheckInvocation.java:
##########
@@ -534,7 +534,7 @@ public void testUpdateSomeColumnsUsed() throws Exception {
     assertEquals(1, inputs.size());
     tableObj = inputs.get(0);
     assertEquals(2, tableObj.getColumns().size());
-    assertEquals("j", tableObj.getColumns().get(0));
+    assertEquals("j", tableObj.getColumns().get(0 ));

Review Comment:
   fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to