ramesh0201 commented on code in PR #3302:
URL: https://github.com/apache/hive/pull/3302#discussion_r880692865
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -314,12 +314,10 @@ public void load(MapJoinTableContainer[] mapJoinTables,
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new HiveException(e);
- } catch (IOException e) {
- throw new HiveException(e);
- } catch (SerDeException e) {
- throw new HiveException(e);
} catch (Exception e) {
throw new HiveException(e);
+ } finally {
+ loadExecService.shutdownNow();
Review Comment:
Yes, Agree. Thanks for pointing this. Also added a null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
