pvary commented on code in PR #3103:
URL: https://github.com/apache/hive/pull/3103#discussion_r890988670
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/msck/MsckAnalyzer.java:
##########
@@ -87,7 +87,8 @@ public void analyzeInternal(ASTNode root) throws
SemanticException {
}
if (repair && AcidUtils.isTransactionalTable(table)) {
- outputs.add(new WriteEntity(table, WriteType.DDL_EXCLUSIVE));
+ outputs.add(new WriteEntity(table,
AcidUtils.isLocklessReadsEnabled(table, conf) ?
Review Comment:
Maybe a little late, maybe it is not viable, but I feel that we spread this
checks all around the code now. Would it be possible to translate the
`WriteType` to the lock type in one place instead?
Maybe in a different PR later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
