zhangbutao commented on code in PR #3304:
URL: https://github.com/apache/hive/pull/3304#discussion_r891009617
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java:
##########
@@ -210,6 +225,12 @@ protected void creatEnv(Configuration conf) throws
Exception {
client.dropDatabase(DBNAME1, true, true, true);
client.dropDatabase(DBNAME2, true, true, true);
+ try {
+ client.dropDataConnector(DCNAME1, true, true);
+ client.dropDataConnector(DCNAME2, true, true);
+ } catch (NoSuchObjectException e) {
+ // no op
Review Comment:
When we are dropping dataconnector whch does not exists, this line will
throw NoSuchObjectException though passing ifnotexists argument(true):
https://github.com/apache/hive/blob/cdb1052e24ca493c6486fef3dd8956dde61be834/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java#L2045
If this is a bug, i will fix it in another pr :). thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
