deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r893190254
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -3087,7 +3090,24 @@ private void insertTxnComponents(long txnid, LockRequest
rqst, Connection dbConn
String tblName = normalizeCase(lc.getTablename());
String partName = normalizePartitionCase(lc.getPartitionname());
OperationType opType =
OperationType.fromDataOperationType(lc.getOperationType());
-
+ if (opType.getSqlConst().equals(OperationType.CTAS.getSqlConst())) {
Review Comment:
why do you even need to create locks for CTAS with this approach? that won't
work as select doesn't even use any locking and we shouldn't add one. Why can't
we stick to checkLock method and only check for Excl_Write and Exclusive locks
in case of CTAS operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
