hmangla98 commented on code in PR #3352:
URL: https://github.com/apache/hive/pull/3352#discussion_r893342479
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1089,9 +1089,8 @@ private boolean
needBootstrapAcidTablesDuringIncrementalDump() {
// of the ACID tables might be included for bootstrap during incremental
dump. For old policy, its because the table
// may not satisfying the old policy but satisfying the new policy. For
filter, it may happen that the table
// is renamed and started satisfying the policy.
- return ((!work.replScope.includeAllTables())
- || (previousReplScopeModified())
- || conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES));
+ return !work.replScope.includeAllTables() || previousReplScopeModified()
|| !tablesForBootstrap.isEmpty()
Review Comment:
Actually, function name "needBootstrapAcidTablesDuringIncrementalDump" is
itself intuitive enough to signify that if tablesForBootstrap is non-empty, we
need to bootstrap them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
