szlta commented on code in PR #3354:
URL: https://github.com/apache/hive/pull/3354#discussion_r895723865


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -381,100 +400,67 @@ private CloseableIterable<T> newAvroIterable(
       Avro.ReadBuilder avroReadBuilder = Avro.read(inputFile)
           .project(readSchema)
           .split(task.start(), task.length());
+

Review Comment:
   nit: Should we keep the original exception ("Vectorized execution is not yet 
supported for Iceberg avro...") here in case the inMemoryDataModel==HIVE ?
   In theory HiveIcebergStorageHandler should prevent such combination, just 
wanted to know if this was a conscious decision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to