deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r896696959
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5297,6 +5303,28 @@ is performed on that db (e.g. show tables, created
table, etc).
return response;
}
}
+
+ if (checkForConcurrentCtas && isValidTxn(txnId)) {
Review Comment:
embed this check with above zeroWaitReadEnabled
````
if ((zeroWaitReadEnabled || isExclusiveCTAS) && isValidTxn(txnId)) {
....
if (lockType == LockType.SHARED_READ || isExclusiveCTAS) {
....
````
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5297,6 +5303,28 @@ is performed on that db (e.g. show tables, created
table, etc).
return response;
}
}
+
+ if (checkForConcurrentCtas && isValidTxn(txnId)) {
Review Comment:
embed this check with the above zeroWaitReadEnabled
````
if ((zeroWaitReadEnabled || isExclusiveCTAS) && isValidTxn(txnId)) {
....
if (lockType == LockType.SHARED_READ || isExclusiveCTAS) {
....
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
