deniskuzZ commented on code in PR #3372:
URL: https://github.com/apache/hive/pull/3372#discussion_r897628576
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java:
##########
@@ -160,14 +162,14 @@ public static void updatePmfProperties(Configuration
conf) {
boolean readLockAcquired = true;
try {
// if pmf properties change, need to update, release read lock and take
write lock
- if (prop == null || pmf == null || !propsFromConf.equals(prop)) {
+ if (pmf == null || !propsFromConf.equals(prop)) {
Review Comment:
unnecessary null check, `!propsFromConf.equals(prop)` covers it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
