zabetak commented on code in PR #3364:
URL: https://github.com/apache/hive/pull/3364#discussion_r897663284
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/JdbcSerDe.java:
##########
@@ -131,7 +131,8 @@ public void initialize(Configuration configuration,
Properties tableProperties,
row = new ArrayList<>(hiveColumnNames.length);
}
} catch (Exception e) {
- throw new SerDeException("Caught exception while initializing the
SqlSerDe", e);
+ log.error("Caught exception while initializing the SqlSerDe", e);
+ throw new SerDeException(e);
Review Comment:
The method `toSQLException` indeed uses the message from
`CommandProcessorException` so in this case "Caught exception while
initializing the SqlSerDe" but it also restores the `cause` which contains the
original message. Usually when an exception is printed the stack trace contains
all causes along with their messages so that's why I am not still sure why we
lose the original message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
