sourabh912 commented on code in PR #3381:
URL: https://github.com/apache/hive/pull/3381#discussion_r902988116


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -461,6 +459,14 @@ public Thread newThread(@NotNull Runnable r) {
     // TODO: AcceptQueueSize needs to be higher for HMS
     connector.setAcceptQueueSize(maxWorkerThreads);
     // TODO: Connection keepalive configuration?
+    connector.addBean(new HttpChannel.Listener() {
+      @Override
+      public void onComplete(Request request) {
+        LOG.debug("Request " + request + " is completed. HttpChannel was: " + 
request.getHttpChannel()
+            + ", HttpTransport: " + 
request.getHttpChannel().getHttpTransport());
+        HMSHandler.cleanupHandlerContext();

Review Comment:
   `testJDOPersistanceManagerCleanup` in TestHiveMetaStore is testing that. The 
failure in that test led to the fixes proposed in this patch. Without this 
patch, testJDOPersistanceManagerCleanup() fails in Thrift over HTTP mode. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to