cmunkey commented on code in PR #3365:
URL: https://github.com/apache/hive/pull/3365#discussion_r903131112
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/AbortTxnHandler.java:
##########
@@ -39,6 +48,19 @@ public void handle(Context withinContext) throws Exception {
if (!ReplUtils.includeAcidTableInDump(withinContext.hiveConf)) {
return;
}
+
+ if (ReplUtils.filterTransactionOperations(withinContext.hiveConf)) {
+ String contextDbName =
StringUtils.normalizeIdentifier(withinContext.replScope.getDbName());
+ GetTxnWriteIdsRequest request = new
GetTxnWriteIdsRequest(eventMessage.getTxnId());
+ request.setDbName(contextDbName);
+ GetTxnWriteIdsResponse response =
withinContext.db.getMSC().getTxnWriteIds(request);
Review Comment:
Ok, I changed how this is done.
TxnHandler.abortTxn() will check if the txn had allocated writeids, and
attach the databases to the AbortTxnEvent. During REPL DUMP, when processing
the AbortTxnEvent, add the event to the dump only if the AbortTxnEvent affected
the database being dumped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
