deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r903452007
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -3225,6 +3237,14 @@ public static String getPathSuffix(long txnId) {
return (SOFT_DELETE_PATH_SUFFIX + String.format(DELTA_DIGITS, txnId));
}
+ public static boolean isExclusiveCTASEnabled(Configuration conf) {
+ return HiveConf.getBoolVar(conf, ConfVars.TXN_CTAS_X_LOCK);
+ }
+
+ public static boolean isExclusiveCTASEnabled(Table t, Configuration conf) {
+ return HiveConf.getBoolVar(conf, ConfVars.TXN_CTAS_X_LOCK) &&
isTransactionalTable(t);
Review Comment:
if you'll be submitting new fixes, could we please rename just this method
to `isTableExclusiveCTASEnabled` to avoid confusion with
`isExclusiveCTASEnabled` or just remove isExclusiveCTASEnabled - it's using in
1 place so you could just directly access conf there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
