pvary commented on code in PR #3379: URL: https://github.com/apache/hive/pull/3379#discussion_r904602688
########## itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcTimeout.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hive.jdbc; + +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hdfs.DFSUtil; +import org.apache.hadoop.hdfs.HAUtil; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.conf.HiveConf.ConfVars; +import org.apache.hive.jdbc.miniHS2.MiniHS2; +import org.apache.hive.service.cli.HiveSQLException; +import org.apache.hive.service.cli.session.HiveSessionHook; +import org.apache.hive.service.cli.session.HiveSessionHookContext; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; +import org.junit.*; + +import java.sql.*; +import java.util.Collection; +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicInteger; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +public class TestJdbcTimeout { + + private static MiniHS2 miniHS2 = null; + + @BeforeClass + public static void beforeTest() throws Exception { + Class.forName(MiniHS2.getJdbcDriverName()); + HiveConf conf = new HiveConf(); + conf.setBoolVar(ConfVars.HIVE_SUPPORT_CONCURRENCY, false); + miniHS2 = new MiniHS2.Builder().withConf(conf).build(); + miniHS2.start(new HashMap<>()); + } + + @AfterClass + public static void afterTest() throws Exception { + if (miniHS2 != null && miniHS2.isStarted()) { + miniHS2.stop(); + } + } + + @Test + public void testConnection() throws Exception { + AtomicInteger goodCounter = new AtomicInteger(0); + AtomicInteger badCounter = new AtomicInteger(0); + DriverManager.setLoginTimeout(2); + String url = miniHS2.getJdbcURL(); + Runnable run = () -> { + try (Connection conn = DriverManager.getConnection(url)) { + goodCounter.incrementAndGet(); + try (Statement stmt = conn.createStatement()) { + stmt.execute("SELECT reflect('java.lang.Thread', 'sleep', 3000L)"); + } + } catch (Exception exception) { + badCounter.incrementAndGet(); + } + }; + Thread conn1 = new Thread(run); + Thread conn2 = new Thread(run); + conn1.start(); + conn2.start(); + assertEquals(goodCounter.get(), 1); Review Comment: Couldn't this become flaky, if the `getConnection` is slow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
