zabetak commented on code in PR #3399:
URL: https://github.com/apache/hive/pull/3399#discussion_r904770029
##########
Jenkinsfile:
##########
@@ -279,15 +279,6 @@ reinit_metastore $dbType
time docker rm -f dev_$dbType || true
'''
}
- stage('verify') {
Review Comment:
In principle the tests in `verify` stage are more complete so could
potentially replace completely all the other stages.
However, I find the `init-metastore` stage still useful cause it launches
the various types of metastores using the hive-dev-box logic outside the unit
test framework (classpaths may be different etc). This is closer to how a
metastore is used in production so I think it is useful to have them as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
