pvary commented on code in PR #3379: URL: https://github.com/apache/hive/pull/3379#discussion_r904993120
########## itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcTimeout.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hive.jdbc; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hive.jdbc.miniHS2.MiniHS2; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.Test; + +import java.sql.DriverManager; +import java.sql.Statement; +import java.util.HashMap; + +import static org.junit.Assert.assertEquals; + +public class TestJdbcTimeout { + + private static MiniHS2 miniHS2 = null; + + @BeforeClass + public static void beforeTest() throws Exception { + Class.forName(MiniHS2.getJdbcDriverName()); + HiveConf conf = new HiveConf(); + conf.setVar(HiveConf.ConfVars.HIVE_LOCK_MANAGER, "org.apache.hadoop.hive.ql.lockmgr.EmbeddedLockManager"); + miniHS2 = new MiniHS2.Builder().withConf(conf).build(); + miniHS2.start(new HashMap<>()); + } + + @AfterClass + public static void afterTest() throws Exception { + if (miniHS2 != null && miniHS2.isStarted()) { + miniHS2.stop(); + } + } + + @Test + public void testDriverManagerLoginTimeout() throws Exception { + DriverManager.setLoginTimeout(10); + String url = miniHS2.getJdbcURL("default"); + try (HiveConnection conn = (HiveConnection) DriverManager.getConnection(url)) { + assertEquals(10000, conn.getLoginTimeout()); + assertEquals(0, conn.getSocketTimeout()); + } + } + + @Test + public void testParameterLoginTimeout() throws Exception { + DriverManager.setLoginTimeout(10); + String url = miniHS2.getJdbcURL("default", "loginTimeout=20000"); + try (HiveConnection conn = (HiveConnection) DriverManager.getConnection(url)) { + assertEquals(20000, conn.getLoginTimeout()); + assertEquals(0, conn.getSocketTimeout()); + } + } + + @Test + public void testParameterSocketTimeout() throws Exception { + DriverManager.setLoginTimeout(0); + String url = miniHS2.getJdbcURL("default", "socketTimeout=10000"); + try (HiveConnection conn = (HiveConnection) DriverManager.getConnection(url)) { + assertEquals(0, conn.getLoginTimeout()); + assertEquals(10000, conn.getSocketTimeout()); + } + } + + @Test + public void testLoginTimeoutDoesNotAffectSocketTime() throws Exception { Review Comment: For Postgres: https://stackoverflow.com/questions/56261716/whats-the-difference-between-logintimeout-connecttimeout-and-sockettimeout-in#:~:text=connectTimeout%20specifies%20how%20long%20to,server%20before%20throwing%20an%20error - connectTimeout specifies how long to wait for a TCP network connection to get established - loginTimeout specifies how long the whole process of logging into the database is allowed to take - socketTimeout specifies how long the client will wait for a response to a command from the server before throwing an error For MySQL, I do not see `loginTimeout`, but I might miss something So basically the difference is that if the `login` process takes long, then we might end up avoiding the `connectTimeout` and the `socketTimeout`, but might fail when the `loginTimeout` is reached. OTOH I am not sure how the HS2 handles long login times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
