pvary commented on code in PR #3362:
URL: https://github.com/apache/hive/pull/3362#discussion_r907324564
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -109,8 +115,8 @@ public void commitTask(TaskAttemptContext originalContext)
throws IOException {
TaskAttemptID attemptID = context.getTaskAttemptID();
JobConf jobConf = context.getJobConf();
- Collection<String> outputs =
HiveIcebergStorageHandler.outputTables(context.getJobConf());
- Map<String, HiveIcebergWriter> writers =
Optional.ofNullable(WriterRegistry.writers(attemptID))
+ Set<String> outputs =
Sets.newHashSet(HiveIcebergStorageHandler.outputTables(context.getJobConf()));
Review Comment:
Could we change the return type for `outputTables` to `Set`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
