dengzhhu653 commented on code in PR #3386:
URL: https://github.com/apache/hive/pull/3386#discussion_r908007753


##########
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java:
##########
@@ -106,58 +114,64 @@ public ExecuteStatementOperation 
newExecuteStatementOperation(HiveSession parent
     return executeStatementOperation;
   }
 
-  public GetTypeInfoOperation newGetTypeInfoOperation(HiveSession 
parentSession) {
+  public GetTypeInfoOperation newGetTypeInfoOperation(HiveSession 
parentSession)
+      throws HiveSQLException {

Review Comment:
   My idea is that our thrift apis are good at handling the HiveSQLException 
now, and finally we can see HiveSQLException throwing at the client side even 
when we create another exception type, so if we can pass the server error 
message to the client side, it's ok. How about introducing another `errorCode` 
for this?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to