pvary commented on code in PR #3362:
URL: https://github.com/apache/hive/pull/3362#discussion_r908302321
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -231,25 +314,47 @@ public void commitJob(JobContext originalContext) throws
IOException {
*/
@Override
public void abortJob(JobContext originalContext, int status) throws
IOException {
- JobContext jobContext = TezUtil.enrichContextWithVertexId(originalContext);
- JobConf jobConf = jobContext.getJobConf();
+ abortJobs(Collections.singletonList(originalContext));
+ }
+
+ public void abortJobs(List<JobContext> jobContexts, JobStatus.State
runState) throws IOException {
+ int state = runState.getValue();
+ if (state != JobStatus.FAILED && state != JobStatus.KILLED) {
Review Comment:
Isn't it only us who is calling this method, and we only call it with
`FAILED`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
