dengzhhu653 commented on PR #3124: URL: https://github.com/apache/hive/pull/3124#issuecomment-1170901042
> > sorry for the poor changes that I made > > @dengzhhu653: [HIVE-23633](https://issues.apache.org/jira/browse/HIVE-23633) solved a serious issue. That was important to get in. Any specific reason you think this is solution is much better? Before this, There are 76 overriden methods in QueryWrapper, most of which take no effect, so after cleaned, there are about 18 methods in QueryWrapper, it can reduce further maintaince of this proxy class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
