dengzhhu653 commented on code in PR #3386:
URL: https://github.com/apache/hive/pull/3386#discussion_r920628083
##########
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java:
##########
@@ -94,6 +95,14 @@ public synchronized void start() {
@Override
public synchronized void stop() {
super.stop();
+ for (Operation operation : getOperations()) {
+ try {
Review Comment:
we actually do not cancel operations at all before the changes, instead we
shutdown the backgroud pool running the operations:
https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/session/SessionManager.java#L367
this does not guarantee that the HiveServer2 would stop immediately when
hs2.stop is finished. In some cases, it would wait for all operations done
before exiting, and some operation's local files may not be cleaned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
