pvary commented on code in PR #3445:
URL: https://github.com/apache/hive/pull/3445#discussion_r924468260
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -346,6 +346,23 @@ default List<FieldSchema>
acidSortColumns(org.apache.hadoop.hive.ql.metadata.Tab
return Collections.emptyList();
}
+ /**
+ * Check if the underlying storage handler implementation supports sort
columns.
+ * @return true if the storage handler can support it
+ */
+ default boolean supportsSortColumns() {
+ return false;
+ }
+
+ /**
+ * Collect the columns that are used to sort the content of the data files
+ * @param table the table which is being sorted
+ * @return the list of columns that are used during data sorting
+ */
+ default List<FieldSchema>
sortColumns(org.apache.hadoop.hive.ql.metadata.Table table) {
+ return Collections.emptyList();
Review Comment:
Shall we throw an exception here, to find issues sooner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
