saihemanth-cloudera commented on code in PR #3221:
URL: https://github.com/apache/hive/pull/3221#discussion_r924692232
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -5425,6 +5492,55 @@ private void
removeUnusedColumnDescriptor(MColumnDescriptor oldCD) {
}
}
+ /**
+ * Checks if a serde info has any remaining references by storage descriptors
+ * in the db. If it does not, then delete the SerDe info. If it does, then
do nothing.
+ * @param oldSerDeInfo the serde info to delete if it is no longer
referenced anywhere
+ */
+ private void removeUnusedSerDeInfo(MSerDeInfo oldSerDeInfo) {
+ if (oldSerDeInfo == null) {
+ return;
+ }
+ LOG.debug("executing removeUnusedSerDeInfo");
Review Comment:
Wouldn't it be ideal to log the value of the oldSerDeInfo variable in the
debug message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
