amansinha100 commented on code in PR #3420:
URL: https://github.com/apache/hive/pull/3420#discussion_r925716438
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestMaterializedViewRebuild.java:
##########
@@ -97,7 +91,7 @@ public void
testWhenMajorCompactionThenIncrementalMVRebuildIsStillAvailable() th
txnHandler.cleanTxnToWriteIdTable();
List<String> result = execSelectAndDumpData("explain cbo alter
materialized view " + MV1 + " rebuild", driver, "");
- Assert.assertEquals(INCREMENTAL_REBUILD_PLAN, result);
+ Assert.assertEquals(FULL_REBUILD_PLAN, result);
Review Comment:
HIVE-26375 jira talks about update/delete cases affected by major
compaction. In this case, an insert was done so shouldn't that be supported
for incremental rebuild ?
EDIT: I see below that
testSecondRebuildCanBeIncrementalAfterMajorCompaction() does indeed allow
incremental for the second rebuild. Maybe you can clarify why there is a
difference in the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
