cmunkey commented on PR #3439:
URL: https://github.com/apache/hive/pull/3439#issuecomment-1190643817
Since these are only logging messages, won't the log line already have the
timestamp in readable format?
Won't it cause extra confusion if the log line and the message have a
different times?
ReplState.log() does:
public void log(LogTag tag) {
try {
REPL_LOG.info("REPL::{}: {}", tag.name(),
mapper.writeValueAsString(this));
} catch (Exception exception) {
REPL_LOG.error("Could not serialize REPL log: {}",
exception.getMessage());
}
}
}
The object instance, BootstrapDumpBegin for instance, is created before the
LOG.info(),
so could potentially have a different instance. Yes, converting from millis
to seconds does
usually make them close, but log messages have:
2022-07-20 18:54:47,334 INFO
which is milliseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
