SourabhBadhya commented on code in PR #3457:
URL: https://github.com/apache/hive/pull/3457#discussion_r927295389
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -485,6 +480,26 @@ private void clearLocksAndHB() {
stopHeartbeat();
}
+ private void cleanupDirForCTAS() {
Review Comment:
Currently `Context ctx` is not available during `rollbackTxn` which is why I
chose to store the object.
However I agree passing `Context ctx` is better.
There are multiple ways of doing this -
First would be to involve passing `Context ctx` to `rollbackTxn` method
which would change the HiveTxnManager API itself (I particularly dont like this
since this would be a breaking change).
Or we could create a new function in the `HiveTxnManager` interface of the
same name and call it from the driver when rollback conditions are satisfied.
My idea was to avoid both and initialise the destination in one of the
existing APIs but I am open for any other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
