abstractdog commented on code in PR #3468:
URL: https://github.com/apache/hive/pull/3468#discussion_r927484258
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java:
##########
@@ -96,14 +98,15 @@ public String[] getLocations(InputSplit split) throws
IOException {
}
@VisibleForTesting
- static SplitLocationProvider
getCustomSplitLocationProvider(LlapRegistryService serviceRegistry, Logger LOG)
throws
- IOException {
+ static SplitLocationProvider
getCustomSplitLocationProvider(LlapRegistryService serviceRegistry,
+ int clusterReadyTimeoutMs, Logger LOG) throws IOException {
LOG.info("Using LLAP instance " + serviceRegistry.getApplicationId());
Collection<LlapServiceInstance> serviceInstances =
- serviceRegistry.getInstances().getAllInstancesOrdered(true);
+
serviceRegistry.getInstances(clusterReadyTimeoutMs).getAllInstancesOrdered(true);
Review Comment:
okay, I've just realized this is not what we want
clusterReadyTimeoutMs is for zookeeper readiness, but we want to wait x ms
until at least 1 LLAP instance is up, which needs custom logic here (some
polling)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
