nrg4878 commented on code in PR #3386:
URL: https://github.com/apache/hive/pull/3386#discussion_r933752080
##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -438,7 +439,7 @@ public synchronized void init(HiveConf hiveConf) {
}
// Add a shutdown hook for catching SIGTERM & SIGINT
- ShutdownHookManager.addShutdownHook(() -> hiveServer2.stop());
+ ShutdownHookManager.addShutdownHook(() -> graceful_stop());
Review Comment:
if the default is graceful_stop() when you CNTRL-C the HS2 process, should
we decrease the default timeout from 30 mins to something lower? if HS2 does
not have any running queries, I think it would be equivalent to a force
shutdown. But regardless, just thinking out loud.
if there is a long running query, how would one issue a force shutdown ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
