deniskuzZ commented on code in PR #3457:
URL: https://github.com/apache/hive/pull/3457#discussion_r934518439
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7983,7 +7984,17 @@ protected boolean enableColumnStatsCollecting() {
return true;
}
- private Path getCtasLocation(CreateTableDesc tblDesc) throws
SemanticException {
+ private Path getCtasLocation(CreateTableDesc tblDesc, boolean
createTableWithSuffix) throws SemanticException {
+ Path destinationPath = getCtasLocationWithoutSuffix(tblDesc);
+ if (createTableWithSuffix) {
+ long txnId = ctx.getHiveTxnManager().getCurrentTxnId();
+ String suffix = AcidUtils.getPathSuffix(txnId);
+ destinationPath = new Path(destinationPath.toString() + suffix);
+ }
+ return destinationPath;
+ }
+
+ private Path getCtasLocationWithoutSuffix(CreateTableDesc tblDesc) throws
SemanticException {
Review Comment:
please keep it as `getCtasLocation` and call overloaded
getCtasLocation(tblDesc, false)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
