t3rmin4t0r commented on code in PR #3492:
URL: https://github.com/apache/hive/pull/3492#discussion_r936143948
##########
pom.xml:
##########
@@ -58,7 +58,7 @@
<module>testutils</module>
<module>packaging</module>
<module>standalone-metastore</module>
- <module>upgrade-acid</module>
Review Comment:
Remove the pom.xml from the PR
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFMapIndexStringScalar.java:
##########
@@ -66,10 +66,13 @@ public int findScalarInMap(MapColumnVector mapColumnVector,
int mapBatchIndex) {
byte[][] keyVector = keyColVector.vector;
int[] keyStart = keyColVector.start;
int[] keyLength = keyColVector.length;
+ final boolean isRepeating = keyColVector.isRepeating;
for (int i = 0; i < count; i++) {
final int keyOffset = offset + i;
+ final int len = isRepeating? keyLength[i]: keyLength[keyOffset];
Review Comment:
Is that supposed to be [i] or [0]
The two rows look a bit wrong there.
I would write keyOffset = isRepeating ? 0 : offset + i
if the intention was to use =0 for all repeating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
