deniskuzZ commented on code in PR #3489:
URL: https://github.com/apache/hive/pull/3489#discussion_r941042919
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -145,59 +145,54 @@ public void init(AtomicBoolean stop) throws Exception {
setName(workerName);
}
+ /**
+ * This doesn't throw any exceptions because we don't want the Compaction to
appear as failed
+ * if stats gathering fails since this prevents Cleaner from doing it's job
and if there are
+ * multiple failures, auto initiated compactions will stop which leads to
problems that are
+ * much worse than stale stats.
+ *
+ * todo: longer term we should write something
COMPACTION_QUEUE.CQ_META_INFO. This is a binary
+ * field so need to figure out the msg format and how to surface it in SHOW
COMPACTIONS, etc
+ *
+ * @param ci Information about the compaction being run
+ * @param conf The hive configuration object
+ * @param userName The user to run the statistic collection with
+ * @param compactionQueueName The name of the compaction queue
+ */
@VisibleForTesting
- @ThreadSafe
- static final class StatsUpdater {
- private static final Logger LOG =
LoggerFactory.getLogger(StatsUpdater.class);
-
- /**
- * This doesn't throw any exceptions because we don't want the Compaction
to appear as failed
- * if stats gathering fails since this prevents Cleaner from doing it's
job and if there are
- * multiple failures, auto initiated compactions will stop which leads to
problems that are
- * much worse than stale stats.
- *
- * todo: longer term we should write something
COMPACTION_QUEUE.CQ_META_INFO. This is a binary
- * field so need to figure out the msg format and how to surface it in
SHOW COMPACTIONS, etc
- *
- * @param ci Information about the compaction being run
- * @param conf The hive configuration object
- * @param userName The user to run the statistic collection with
- * @param compactionQueueName The name of the compaction queue
- */
- static void gatherStats(CompactionInfo ci, HiveConf conf, String userName,
String compactionQueueName) {
- try {
- if (!ci.isMajorCompaction()) {
- return;
- }
+ protected static void gatherStats(CompactionInfo ci, HiveConf conf, String
userName, String compactionQueueName) {
Review Comment:
I think it would be better to extract StatsUpdater Into a standalone service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
