zabetak commented on code in PR #3498: URL: https://github.com/apache/hive/pull/3498#discussion_r942232816
########## hbase-handler/src/java/org/apache/hadoop/hive/hbase/ResultWritable.java: ########## @@ -26,8 +26,8 @@ import org.apache.hadoop.hbase.KeyValue; import org.apache.hadoop.hbase.KeyValueUtil; import org.apache.hadoop.hbase.client.Result; -import org.apache.hadoop.hbase.protobuf.ProtobufUtil; -import org.apache.hadoop.hbase.protobuf.generated.ClientProtos; +import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil; +import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos; Review Comment: OK, let me rephrase a bit to be sure I understand the current situation. After the changes in this PR, most parts of Hive will use protobuf 3.21.4 while the HBase module will keep using protobuf 2.5.0 via the shaded packages. Is that correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
