saihemanth-cloudera commented on code in PR #3312:
URL: https://github.com/apache/hive/pull/3312#discussion_r950617222
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1926,7 +1926,7 @@ public void create_dataconnector(final DataConnector
connector)
} catch (NoSuchObjectException e) {
// expected
}
-
+ firePreEvent(new PreCreateDataConnectorEvent(connector, this));
Review Comment:
We are calling firePreevent for PreCreateDataConnectorEvent here and at
L#1887 (create_dataconnector_core api). Also, create_dataconnector_core() API
is a private method and is only being called in this method. So I don't think
we would need this firePreEvent here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
