zhangbutao commented on PR #3388: URL: https://github.com/apache/hive/pull/3388#issuecomment-1232566312
> Let me know what you think. logically, it is similar to ur implementation. I am using the boolean isOpen while you are using a method. @nrg4878 Yes, I wrapped a method to check if conn are closed, and you check conn is alive by isValid(). I think the main difference is that you changes focus on in _AbstractJDBCConnectorProvider::getConnection()_ , so it is suitable for all jdbc datasources(MySQL, Oracle..), but in this way, how can we customize timeouts and retries for each jdbc datasource? meanwhile, each jdbc datasouce may have different timeout parameter or others, it seems that we can not customize jdbc-url for all jdbc datasources in this way. My change focus on customizing jdbc-url for each jdbc datasource, in this change, i added parameters (connectTimeout and autoReconnect and maxReconnects) in _MySQLConnectorProvider::getConnectionProperties()_, and this parameters can be override by connector DCPROPERTIES. We also can add timeout conn for other jdbc datasource in this way, e.g Oracle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
