veghlaci05 commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r960277912
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7036,4 +7036,15 @@ public void syncFromConf(HiveConf conf) {
set(e.getKey(), e.getValue());
}
}
+
+ public List<RegexMatchingConfEntry> getMatchingEntries(Pattern regex) {
+ List<RegexMatchingConfEntry> matchingEntries = new ArrayList<>();
+ for (Map.Entry<String, String> entry : this) {
+ Matcher matcher = regex.matcher(entry.getKey());
+ if (matcher.matches()) {
+ matchingEntries.add(new RegexMatchingConfEntry(entry.getKey(),
matcher));
Review Comment:
Only `entry.getMatcher().group(0)` used to times.
However, I think this method should be generic and return both the key, and
the corresponding matcher. The key is always required because it is used to
obtain the config value. In some cases, like the current, the matcher also can
be useful: We also need the poolname part of the key, and by using a grouped
regex it is already available in the matcher. This eliminates the need of
splitting/matching the key again in HiveServer2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
