szlta commented on code in PR #3551:
URL: https://github.com/apache/hive/pull/3551#discussion_r960552486
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java:
##########
@@ -248,9 +245,12 @@ public void initialize(
requestedSchema = DataWritableReadSupport
.getRequestedSchema(indexAccess, columnNamesList, columnTypesList,
fileSchema, configuration);
- Path path = wrapPathForCache(filePath, cacheKey, configuration, blocks,
cacheTag);
+ //TODO: For data cache this needs to be fixed and passed to reader.
+ //Path path = wrapPathForCache(filePath, cacheKey, configuration, blocks,
cacheTag);
Review Comment:
I don't quite get this change. It essentially turns off LLAP data caching of
Parquet bytes, I'm not sure if this was intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
