dengzhhu653 commented on code in PR #3555:
URL: https://github.com/apache/hive/pull/3555#discussion_r962796572
##########
service/src/java/org/apache/hive/service/auth/ldap/CustomQueryFilterFactory.java:
##########
@@ -76,6 +76,19 @@ public void apply(DirSearch client, String user) throws
AuthenticationException
}
}
}
+
+ // try a generic user search
+ String userSearchQuery = query.replace("{0}", user);
Review Comment:
if the query does not contain '{0}', the `userSearchQuery` would be the
same as `query`, which makes
TestLdapAtnProviderWithMiniDS#testCustomQueryNegative fail in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
