kasakrisz commented on code in PR #3552:
URL: https://github.com/apache/hive/pull/3552#discussion_r964371311
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -977,4 +977,11 @@ public Configuration get() {
return conf;
}
}
+
+ @Override
+ public String getCurrentSnapshot(org.apache.hadoop.hive.ql.metadata.Table
hmsTable) {
Review Comment:
String gives us more flexibility:
* I had a version when more than one field was returned from the iceberg
snapshot serialized into json: snapshotId + sequenceNumber. Then it turned out
that the snapshotId is enough so far.
* Other than Iceberg storage formats may represents this value with another
type and serialize to String is an option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
