kasakrisz commented on code in PR #3552: URL: https://github.com/apache/hive/pull/3552#discussion_r966581077
########## storage-api/src/java/org/apache/hadoop/hive/common/MaterializationSnapshot.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.common; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; + +import java.io.IOException; +import java.io.StringWriter; +import java.io.UncheckedIOException; +import java.io.Writer; +import java.util.Map; + +/** + * Class to store snapshot data of Materialized view source tables. + * The data represents the state of the source tables when the view was created/last rebuilt. + */ +public class MaterializationSnapshot { + + public static MaterializationSnapshot fromJson(String jsonString) { + try { + return new ObjectMapper().readValue(jsonString, MaterializationSnapshot.class); + } catch (JsonProcessingException e) { + // this is not a jsonString, fall back to treating it as ValidTxnWriteIdList + return new MaterializationSnapshot(jsonString); + } + } + + // Snapshot of native ACID tables. + private String validTxnList; + // Snapshot of non-native ACID and insert-only transactional tables. Key is the fully qualified name of the table. + // Value is the unique id of the snapshot provided by the table's storage HiveStorageHandler. + private Map<String, String> tableSnapshots; + + private MaterializationSnapshot() { + } + + public MaterializationSnapshot(String validTxnList) { + this.validTxnList = validTxnList; + this.tableSnapshots = null; + } + + public MaterializationSnapshot(Map<String, String> tableSnapshots) { + this.validTxnList = null; + this.tableSnapshots = tableSnapshots; + } + + /** + * Returns the json representation of this object. + * @return {@link String} containing a json. + */ + public String asJsonString() { + try (Writer out = new StringWriter()) { + new ObjectMapper().writeValue(out, this); + return out.toString(); + } catch (IOException e) { + throw new UncheckedIOException("Unable to convert " + this + " to json", e); + } + } + + @Override + public String toString() { + return "MaterializationSnapshot{" + + "validTxnList='" + validTxnList + '\'' + + ", tableSnapshots=" + tableSnapshots + + '}'; + } + + public String getValidTxnList() { Review Comment: added ########## storage-api/src/java/org/apache/hadoop/hive/common/MaterializationSnapshot.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.common; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; + +import java.io.IOException; +import java.io.StringWriter; +import java.io.UncheckedIOException; +import java.io.Writer; +import java.util.Map; + +/** + * Class to store snapshot data of Materialized view source tables. + * The data represents the state of the source tables when the view was created/last rebuilt. + */ +public class MaterializationSnapshot { + + public static MaterializationSnapshot fromJson(String jsonString) { + try { + return new ObjectMapper().readValue(jsonString, MaterializationSnapshot.class); + } catch (JsonProcessingException e) { + // this is not a jsonString, fall back to treating it as ValidTxnWriteIdList + return new MaterializationSnapshot(jsonString); + } + } + + // Snapshot of native ACID tables. + private String validTxnList; + // Snapshot of non-native ACID and insert-only transactional tables. Key is the fully qualified name of the table. + // Value is the unique id of the snapshot provided by the table's storage HiveStorageHandler. + private Map<String, String> tableSnapshots; + + private MaterializationSnapshot() { + } + + public MaterializationSnapshot(String validTxnList) { + this.validTxnList = validTxnList; + this.tableSnapshots = null; + } + + public MaterializationSnapshot(Map<String, String> tableSnapshots) { + this.validTxnList = null; + this.tableSnapshots = tableSnapshots; + } + + /** + * Returns the json representation of this object. + * @return {@link String} containing a json. + */ + public String asJsonString() { + try (Writer out = new StringWriter()) { + new ObjectMapper().writeValue(out, this); + return out.toString(); + } catch (IOException e) { + throw new UncheckedIOException("Unable to convert " + this + " to json", e); + } + } + + @Override + public String toString() { + return "MaterializationSnapshot{" + + "validTxnList='" + validTxnList + '\'' + + ", tableSnapshots=" + tableSnapshots + + '}'; + } + + public String getValidTxnList() { + return validTxnList; + } + + public Map<String, String> getTableSnapshots() { Review Comment: added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
