InvisibleProgrammer commented on code in PR #3521:
URL: https://github.com/apache/hive/pull/3521#discussion_r972929518
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/CompactionMetricData.java:
##########
@@ -148,6 +152,10 @@ Map<String, Long> getStateCount() {
return new HashMap<>(stateCount);
}
+ public Map<String, Integer> getPoolCount() {
+ return new HashMap<>(poolCount);
Review Comment:
I wonder, what is the reason of copying the poolCount map instead of passing
it to the caller?
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/CompactionMetricData.java:
##########
@@ -45,6 +45,8 @@ final class CompactionMetricData {
private Map<String, Long> stateCount;
+ private Map<String, Integer> poolCount;
Review Comment:
I wonder if the counter can be Long or not. I mean, the `CC_ID` column in
the meta-store database is big int. I don't know our usage statistics but I
wonder: it is possible to have so many compaction requests in pool that Integer
is not enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
