deniskuzZ commented on code in PR #3514:
URL: https://github.com/apache/hive/pull/3514#discussion_r974131463
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCleanerWithReplication.java:
##########
@@ -44,34 +39,25 @@
import org.junit.Test;
import javax.security.auth.login.LoginException;
-import java.io.File;
import java.io.IOException;
-import java.nio.file.Files;
import static org.junit.Assert.assertEquals;
public class TestCleanerWithReplication extends CompactorTest {
private Path cmRootDirectory;
- private static FileSystem fs;
private static MiniDFSCluster miniDFSCluster;
private final String dbName = "TestCleanerWithReplication";
@Before
public void setup() throws Exception {
- conf = new HiveConf();
- TestTxnDbUtil.setConfValues(conf);
- TestTxnDbUtil.cleanDb(conf);
- conf.set("fs.defaultFS", fs.getUri().toString());
+ HiveConf conf = new HiveConf();
+ conf.set("fs.defaultFS",
miniDFSCluster.getFileSystem().getUri().toString());
conf.setBoolVar(HiveConf.ConfVars.REPLCMENABLED, true);
- MetastoreConf.setBoolVar(conf,
MetastoreConf.ConfVars.COMPACTOR_INITIATOR_ON, true);
- TestTxnDbUtil.prepDb(conf);
- ms = new HiveMetaStoreClient(conf);
- txnHandler = TxnUtils.getTxnStore(conf);
+ super.setup(conf);
Review Comment:
minor: no need for super keyword here, setup(conf) is only defined in parent
class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
