difin commented on code in PR #3606:
URL: https://github.com/apache/hive/pull/3606#discussion_r978943267
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java:
##########
@@ -384,7 +384,6 @@ public void parse(Configuration conf, Path rootPath) throws
IOException {
OrcRawRecordMerger.TransactionMetaData.findWriteIDForSynthetcRowIDs(getPath(),
rootPath, conf);
writeId = tmd.syntheticWriteId;
stmtId = tmd.statementId;
- bucketId = AcidUtils.parseBucketId(getPath());
Review Comment:
As I understand we always pass through constructor which sets bucketId. The
class has 2 constructors and the bucket Id is set in both of them. Otherwise it
wouldn't compile, I made bucketId final and final members must be set before
the end of a constructor.
writeId and stmtId depend also on configuration and rootPath which are
passed as arguments to parse method, but bucket Id was depending only on path.
https://github.com/apache/hive/pull/3606/files#diff-f33c72f4823ff07b5fb662959932648b9e96c52f248e44df29bd4e8d550487b2R383-R387:~:text=TransactionMetaData%20tmd%20%3D-,OrcRawRecordMerger,-.TransactionMetaData.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
