dengzhhu653 commented on code in PR #3567: URL: https://github.com/apache/hive/pull/3567#discussion_r980689980
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/LeaderElectionContext.java: ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.metastore.leader; + +import org.apache.commons.lang3.StringUtils; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.common.TableName; +import org.apache.hadoop.hive.metastore.HiveMetaStore; +import org.apache.hadoop.hive.metastore.IHMSHandler; +import org.apache.hadoop.hive.metastore.Warehouse; +import org.apache.hadoop.hive.metastore.conf.MetastoreConf; +import org.apache.hadoop.hive.metastore.leader.LeaderElection.LeadershipStateListener; +import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static java.util.Objects.requireNonNull; + +public class LeaderElectionContext { + + /** + * Types of tasks that exactly have one instance in a given warehouse. + * For those tasks which belong to the same type, they will be running in the same leader. + */ + public enum TTYPE { + HOUSEKEEPING(new TableName(Warehouse.DEFAULT_CATALOG_NAME, "sys", + "metastore_housekeeping_leader"), "housekeeping"), + WORKER(new TableName(Warehouse.DEFAULT_CATALOG_NAME, "sys", + "metastore_worker_leader"), "compactor_worker"), + ALWAYS_TASKS(new TableName(Warehouse.DEFAULT_CATALOG_NAME, "sys", + "metastore_always_tasks_leader"), "always_tasks"); + // Mutex of TTYPE, which can be a nonexistent table + private final TableName mutex; + // Name of TTYPE + private final String name; + + TTYPE(TableName tableName, String name) { + this.mutex = tableName; + this.name = name; + } + public TableName getTableName() { + return mutex; + } + public String getName() { + return name; + } + } + + private final Configuration conf; + private final String servHost; + // Whether the context should be started as a daemon + private final boolean startAsDaemon; + // Audit the event of election + private AuditLeaderListener auditLeaderListener; + // State change listeners group by type + private final Map<TTYPE, List<LeadershipStateListener>> listeners; + // Collection of leader candidates + private final List<LeaderElection> leaderElections = new ArrayList<>(); + // Property for testing, a single leader will be created + public final static String LEADER_IN_TEST = "metastore.leader.election.in.test"; + + private LeaderElectionContext(String servHost, Configuration conf, + Map<TTYPE, List<LeadershipStateListener>> listeners, + boolean startAsDaemon, IHMSHandler handler) throws Exception { + requireNonNull(conf, "conf is null"); + requireNonNull(listeners, "listeners is null"); + this.servHost = servHost; + this.conf = new Configuration(conf); + this.startAsDaemon = startAsDaemon; + String tableName = MetastoreConf.getVar(conf, + MetastoreConf.ConfVars.METASTORE_HOUSEKEEPING_LEADER_AUDITTABLE); + if (StringUtils.isNotEmpty(tableName)) { + TableName table = TableName.fromString(tableName, MetaStoreUtils.getDefaultCatalog(conf), + Warehouse.DEFAULT_DATABASE_NAME); Review Comment: The `default` database takes effect when the configured `tableName` is not specified the database -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
