adoroszlai opened a new pull request, #3635:
URL: https://github.com/apache/hive/pull/3635
## What changes were proposed in this pull request?
Hadoop moved from Log4j1 to Reload4j (HADOOP-18088). The goal of this task
is to prepare Hive for that change:
* Hive build fails with current `useStrictFiltering=true` setting in some
assemblies, due to excluded dependency (log4j) not really being present.
* Exclude `ch.qos.reload4j:*` in addition to current `log4j:*` to avoid
polluting the assemblies and shaded jars.
https://issues.apache.org/jira/browse/HIVE-26579
## How was this patch tested?
CI build was successful:
https://github.com/adoroszlai/hive/actions/runs/3158692928/jobs/5141014133
Built Hive locally, checked artifacts affected by the change still do not
have Log4j1 jar/classes:
```
$ mvn -DskipTests -Pdist clean install
...
[INFO] BUILD SUCCESS
$ tar tzvf
standalone-metastore/metastore-server/target/apache-hive-standalone-metastore-server-4.0.0-alpha-2-SNAPSHOT-bin.tar.gz
| grep log4j
-rw-r--r-- root/root 2731 2020-01-22 16:10
apache-hive-metastore-4.0.0-alpha-2-SNAPSHOT-bin/conf/metastore-log4j2.properties
-rw-r--r-- root/root 24801 2020-01-22 16:10
apache-hive-metastore-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-slf4j-impl-2.18.0.jar
-rw-r--r-- root/root 315115 2020-01-22 16:10
apache-hive-metastore-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-api-2.18.0.jar
-rw-r--r-- root/root 349845 2020-01-22 16:10
apache-hive-metastore-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-1.2-api-2.18.0.jar
-rw-r--r-- root/root 1861441 2020-01-22 16:10
apache-hive-metastore-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-core-2.18.0.jar
$ tar tzvf packaging/target/apache-hive-4.0.0-alpha-2-SNAPSHOT-bin.tar.gz |
grep log4j
-rw------- root/root 3086 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/conf/hive-log4j2.properties.template
-rw------- root/root 2274 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/conf/hive-exec-log4j2.properties.template
-rw------- root/root 1596 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/conf/beeline-log4j2.properties.template
-rw------- root/root 7093 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/conf/llap-daemon-log4j2.properties.template
-rw------- root/root 3558 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/conf/llap-cli-log4j2.properties.template
-rw-r--r-- root/root 2708 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/hcatalog/etc/webhcat/webhcat-log4j2.properties
-rw-r--r-- root/root 349845 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-1.2-api-2.18.0.jar
-rw-r--r-- root/root 315115 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-api-2.18.0.jar
-rw-r--r-- root/root 36166 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-web-2.18.0.jar
-rw-r--r-- root/root 24801 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-slf4j-impl-2.18.0.jar
-rw-r--r-- root/root 1861441 2020-01-22 16:10
apache-hive-4.0.0-alpha-2-SNAPSHOT-bin/lib/log4j-core-2.18.0.jar
$ unzip -t jdbc/target/hive-jdbc-4.0.0-alpha-2-SNAPSHOT-standalone.jar |
grep log4j
testing: hive-log4j2.properties OK
testing: META-INF/org/apache/logging/log4j/ OK
testing: META-INF/org/apache/logging/log4j/core/ OK
testing: META-INF/org/apache/logging/log4j/core/config/ OK
testing: META-INF/org/apache/logging/log4j/core/config/plugins/ OK
testing:
META-INF/org/apache/logging/log4j/core/config/plugins/Log4j2Plugins.dat OK
testing: llap-cli-log4j2.properties OK
testing: llap-daemon-log4j2.properties OK
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
