kasakrisz commented on code in PR #3588:
URL: https://github.com/apache/hive/pull/3588#discussion_r985791359


##########
ql/src/test/results/clientpositive/llap/auto_join21.q.out:
##########
@@ -43,37 +45,38 @@ STAGE PLANS:
                         outputColumnNames: _col0, _col1, _col2, _col3
                         input vertices:
                           1 Map 2
-                        Statistics: Num rows: 1 Data size: 356 Basic stats: 
COMPLETE Column stats: COMPLETE
+                        Statistics: Num rows: 55 Data size: 19580 Basic stats: 
COMPLETE Column stats: COMPLETE
                         Reduce Output Operator
                           key expressions: _col2 (type: string)
                           null sort order: z
                           sort order: +
                           Map-reduce partition columns: _col2 (type: string)
-                          Statistics: Num rows: 1 Data size: 356 Basic stats: 
COMPLETE Column stats: COMPLETE
+                          Statistics: Num rows: 55 Data size: 19580 Basic 
stats: COMPLETE Column stats: COMPLETE
                           value expressions: _col0 (type: string), _col1 
(type: string), _col3 (type: string)
             Execution mode: vectorized, llap
             LLAP IO: all inputs
         Map 2 
             Map Operator Tree:
                 TableScan
                   alias: src2
+                  filterExpr: ((UDFToDouble(key) > 9.0D) and (UDFToDouble(key) 
< 11.0D)) (type: boolean)
                   Statistics: Num rows: 500 Data size: 89000 Basic stats: 
COMPLETE Column stats: COMPLETE
-                  Limit
-                    Number of rows: 0
-                    Statistics: Num rows: 1 Data size: 178 Basic stats: 
COMPLETE Column stats: COMPLETE
+                  Filter Operator
+                    predicate: ((UDFToDouble(key) > 9.0D) and 
(UDFToDouble(key) < 11.0D)) (type: boolean)
+                    Statistics: Num rows: 55 Data size: 9790 Basic stats: 
COMPLETE Column stats: COMPLETE

Review Comment:
   Added comments to the jira.



##########
ql/src/test/queries/clientpositive/antijoin.q:
##########
@@ -44,7 +44,7 @@ explain cbo select a.key, a.value from t1_n55 a left join 
t2_n33 b on a.key=b.ke
 select a.key, a.value from t1_n55 a left join t2_n33 b on a.key=b.key join 
t3_n12 c on a.key=c.key where b.key is null  sort by a.key, a.value;
 
 -- single extra simple filter on right side.
-explain select a.key from t1_n55 a left join t2_n33 b on a.key = b.key where 
b.key is null and b.value > 'val_1';
+explain select a.key from t1_n55 a left join t2_n33 b on a.key = b.key where 
b.key is null and b.value is null;

Review Comment:
   Added comments to the jira.



##########
ql/src/test/results/clientpositive/llap/subquery_ALL.q.out:
##########
@@ -413,8 +413,7 @@ POSTHOOK: Input: default@part
 POSTHOOK: Input: default@part_null_n0
 #### A masked pattern was here ####
 26
-Warning: Shuffle Join MERGEJOIN[37][tables = [$hdt$_1, $hdt$_2]] in Stage 
'Reducer 3' is a cross product
-Warning: Shuffle Join MERGEJOIN[38][tables = [$hdt$_1, $hdt$_2, $hdt$_0]] in 
Stage 'Reducer 4' is a cross product
+Warning: Shuffle Join MERGEJOIN[22][tables = [$hdt$_0, $hdt$_1]] in Stage 
'Reducer 2' is a cross product

Review Comment:
   @difin 
   The plan generated for the select part is simplified but it will be 
executed. Even if the outer query limit is set to 0
   
https://github.com/apache/hive/blob/70562437d369c2f4ab3e879bae519f81d386da3b/ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java#L138
   
   The optimization is enabled only for queries
   
https://github.com/apache/hive/blob/70562437d369c2f4ab3e879bae519f81d386da3b/ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java#L182
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to