dengzhhu653 commented on code in PR #3595:
URL: https://github.com/apache/hive/pull/3595#discussion_r991818756
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -27,14 +27,27 @@
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import java.util.Properties;
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG =
LoggerFactory.getLogger(MySQLConnectorProvider.class);
private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
+ public static final String JDBC_MYSQL_CONFIG_PREFIX = "hive.sql.mysql";
Review Comment:
Could we move these to parent `getConnectionProperties()`. For connection
properties, all start with `hive.sql.connect.` for example, so users can
configure the properties as they want.
Should we also take care of other database vendors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
