rkirtir commented on code in PR #3608:
URL: https://github.com/apache/hive/pull/3608#discussion_r992119900


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsOperation.java:
##########
@@ -39,16 +43,27 @@
  * Operation process of showing compactions.
  */
 public class ShowCompactionsOperation extends 
DDLOperation<ShowCompactionsDesc> {
+
+  static final protected String MAJOR_TYPE = "MAJOR";
+  static final protected String MINOR_TYPE = "MINOR";
+  static final char INITIATED_STATE = 'i';

Review Comment:
   done. Added constants in TxnStore and moved methods in TxnUtil



##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsOperation.java:
##########
@@ -68,6 +83,71 @@ public int execute() throws HiveException {
     return 0;
   }
 
+  private ShowCompactRequest getShowCompactioRequest(ShowCompactionsDesc desc) 
throws MetaException, SemanticException {
+    ShowCompactRequest request = new ShowCompactRequest();
+    if (desc.getDbName() == null && desc.getTbName() != null) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to