amansinha100 commented on code in PR #3674:
URL: https://github.com/apache/hive/pull/3674#discussion_r996527079
##########
common/src/java/org/apache/hadoop/hive/common/auth/HiveAuthUtils.java:
##########
@@ -50,8 +50,21 @@
public class HiveAuthUtils {
private static final Logger LOG =
LoggerFactory.getLogger(HiveAuthUtils.class);
- public static TTransport getSocketTransport(String host, int port, int
loginTimeout) throws TTransportException {
Review Comment:
Since this is a public static method, it is possible it is used by some
client programs and may be needed for backward compatibility. Can we make this
a wrapper and supply the default -1 value ?
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2913,7 +2913,10 @@ public static enum ConfVars {
HIVE_STATS_MAX_NUM_STATS("hive.stats.max.num.stats", (long) 10000,
"When the number of stats to be updated is huge, this value is used to
control the number of \n" +
" stats to be sent to HMS for update."),
-
+ HIVE_THRIFT_MAX_MESSAGE_SIZE("hive.thrift.max.message.size", "1gb",
Review Comment:
Couple of comments:
- there is also a hive.server2.thrift.max.message.size parameter currently
set to 100MB. However, that appears under the http over thrift transport
settings. The naming can get confusing. I think either we consolidate the 2
settings into one or the previous config should have the 'http' string appear
in the name to avoid conflict. If we keep them separate, it would be useful to
understand whether they should be consistent with each other. I don't have the
full context of http over thrift.
- For the default value, most other size specific settings have the full
bytes value specified e.g 100*1024*1024L for 100MB. There are a few settings
which specify the units as you have done but it seems a lot fewer such
instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
